quotas: refactor/expand tests #5688
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 danger |
|
was hoping to flush out a bug here, no success |
dcramer
force-pushed
the
quotas/fix-account-limit
branch
from
f19c50a to
bf95d94
Compare
tkaemming
reviewed
Jul 10, 2017
| protocol='6', | ||
| )) | ||
|
|
||
| # 1 per hour |
There was a problem hiding this comment.
Talked about this Friday, but this needs be the first thing to happen in this test
| self.enforce = enforce | ||
|
|
||
| def __eq__(self, other): | ||
| return isinstance(other, BasicQuota) and hash(self) == hash(other) |
There was a problem hiding this comment.
Technically should match the attributes here and not the hashes
| ) | ||
|
|
||
| def __init__(self, **options): | ||
| pass | ||
|
|
||
| def get_actionable_quotas(self, project, key=None): |
|
Is this something we're still interested in pursuing or can it be closed because it can no longer be merged? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.